refactor: move LockWalletConfirmDialog handling to parent #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@kunal-595 Care to take a look and check if you think this is okay? |
theborakompanioni
force-pushed
the
tbk/v2-lock-wallet-dialog
branch
from
60622d8 to
f47fb82
Compare
kunal-595
reviewed
Jan 23, 2026
Contributor
kunal-595
left a comment
kunal-595
left a comment
There was a problem hiding this comment.
Nice refactor the changes look clean and well thought out:
Moving dialog to ui/jam/ for better reusability
Adding Storybook stories for the different states
Disabling the lock button while locking is in progress
Cleaner state management by lifting to App.tsx
Smart coinjoinInProgress check that also considers scheduled joins
Tested locally and everything works as expected from my side. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves handling
LockWalletConfirmDialogtoAppand adds storybook story (runnpm run storybook:up).